commit 439251d77ec2d240ff35e45efb25b80cb1ff94e6
author Nigel Tao <nigeltao@chromium.org> Fri Aug 26 07:04:16 2022
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Aug 26 07:04:16 2022
tree db35e67f404c4678a33cf26c88d14652552c30ae
parent 3daa9e28091942ddf83c4de26b2effe9cd5b36d5

[Files app] Strip '\n' bytes from ADP identifiers

We don't use Fusebox for ADP volumes yet, but we will shortly and it's
problematic without this adjustment.

Bug: 1292825
Change-Id: Iee866ceeca5db3236ecd93d2297eee744612f960
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3858727
Reviewed-by: Ben Reich <benreich@chromium.org>
Commit-Queue: Ben Reich <benreich@chromium.org>
Auto-Submit: Nigel Tao <nigeltao@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1039618}

chrome/browser/ash/file_manager/documents_provider_root_manager.cc

diff --git a/chrome/browser/ash/file_manager/documents_provider_root_manager.cc b/chrome/browser/ash/file_manager/documents_provider_root_manager.cc
index 990098d..a69b0545 100644
--- a/chrome/browser/ash/file_manager/documents_provider_root_manager.cc
+++ b/chrome/browser/ash/file_manager/documents_provider_root_manager.cc
@@ -183,8 +183,6 @@
 
     RootInfo root_info;
     root_info.authority = root->authority;
-    root_info.root_id = root->root_id;
-    root_info.document_id = root->document_id;
     root_info.title = root->title;
     if (root->summary.has_value())
       root_info.summary = root->summary.value();
@@ -194,6 +192,23 @@
     if (root->mime_types.has_value())
       root_info.mime_types = root->mime_types.value();
 
+    // Strip new lines from the Root and Document IDs.
+    //
+    // Some Android Documents Provider implementations (e.g. Dropbox) have
+    // long, base-64 encoded IDs broken up by '\n' bytes, presumably to help
+    // human readability. However, these IDs become part of URLs (represented
+    // by GURL or storage::FileSystemURL objects) but passed between processes
+    // (e.g. Fusebox) as strings, not C++ objects. Various URL parsing and
+    // unparsing along the way can strip out the '\n' bytes, which breaks exact
+    // string match on the IDs (e.g. ArcDocumentsProviderRootMap map keys).
+    //
+    // New lines within a serialized GURL or storage::FileSystemURL also makes
+    // it harder for line-based tools (e.g. grep) to process log messages.
+    //
+    // To avoid those problems, we strip the '\n' bytes eagerly, here.
+    base::RemoveChars(root->root_id, "\n", &root_info.root_id);
+    base::RemoveChars(root->document_id, "\n", &root_info.document_id);
+
     roots_info.emplace_back(std::move(root_info));
   }
   std::sort(roots_info.begin(), roots_info.end());