Fix NOTREACHED for ProduceSkia() ProduceSkia() should never be called when GrContextType is kNone, aka when GPU accelerated compositing is disabled and skia isn't initialized in the GPU process. Renderer/extension processes are notified about GPU accelerated compositing being disabled asynchronously so they could issue raster work that tries to ProduceSkia() before that point and hit the not reached. Change to just return null in this case to signal failure without crashing. Fixed: 356512109 Change-Id: Ia74149f2136b93b6c07eb5f9de80c45b22ce53ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5753784 Reviewed-by: Peter McNeeley <petermcneeley@chromium.org> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org> Commit-Queue: Kyle Charbonneau <kylechar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1335686}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.