Google Git
Sign in
chromium / chromium / src / 4415acd146ca1e42a095f9f0e3aa58d6379450cf
commit4415acd146ca1e42a095f9f0e3aa58d6379450cf[log] [tgz]
authorAlexis Hetu <sugoi@chromium.org>Thu Mar 13 14:52:04 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Mar 13 14:52:04 2025
treecb5541e0a3cea3eebad5f6a4603e78605ce5ddff
parentadcc5dc063598f998f5b23b27db91f893719736c [diff]
[iOS] Change the KA's leading padding to a leading margin

There was an issue where the leading padding was causing the
suggestion chips to clip at the padding when scrolling them
towards the leading edge.

To solve this issue, the leading padding was removed and an
equivalent layout margin offset was added to the scroll view.
This results in the suggestion chips being at the same onscreen
location as before (there's no visual difference in the initial
state), but suggestions are now visible all the way to the
Keyboard Accessory's leading edge, rather than being hidden in
the padding area when scrolling them towards the leading edge.

Bug: 385172448
Change-Id: If5a5e61985a5b9b8f2f3bc78fd0ffae81d0882d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6343037
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Noémie St-Onge <noemies@google.com>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1432106}
4 files changed
tree: cb5541e0a3cea3eebad5f6a4603e78605ce5ddff
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.