Google Git
Sign in
chromium / chromium / src / 4422d0647b12fcc7852838cef8ffb83b238a66ce
commit4422d0647b12fcc7852838cef8ffb83b238a66ce[log] [tgz]
authorsiyua <siyua@chromium.org>Thu Mar 21 22:05:08 2019
committerCommit Bot <commit-bot@chromium.org>Thu Mar 21 22:05:08 2019
tree4918a5e6e80d5f0eeb7919584d263335931cc73b
parentb9450c73c7d475d010c66fa0fd644cb4077bbc06 [diff]
[AF][Status Chip] Move save card icon into toolbar status chip

1) Change is similar to the one moving LocalCardMigrationIconView into
the status chip.

2) In the browsertes I used card local save flow to verify.
Didn't add more browsertests since all bubbles update icon through
the same UpdateIcon() function, if one bubble works fine then all
types of bubbles and their related save card icon should work fine.

3) Uploaded implementation screenshot in bug comment#3

Bug: 932818
Change-Id: Ibc49c58b5074fbc40022480a88369ae3b665857b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518465
Commit-Queue: Siyu An <siyua@chromium.org>
Reviewed-by: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Peter Boström <pbos@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#643147}
14 files changed
tree: 4918a5e6e80d5f0eeb7919584d263335931cc73b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .