commit | 1870509af54531ba32cc319a5681c258322f1b60 | [log] [tgz] |
---|---|---|
author | Danyao Wang <danyao@chromium.org> | Fri Jan 25 21:25:12 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Fri Jan 25 21:25:12 2019 |
tree | 25e6b62b0e0ea8845d7d38d3b6819e211ec7f559 | |
parent | 2e1939cb542044e19891ac04601cf71cd31ae8b7 [diff] |
Reland "[Nav Experiment] Call LoadIfNecessary() in CWVWebView session restore." This is a reland of b21bf2bb2df4dd44c41bb463e883b9930a116a70 Original change's description: > [Nav Experiment] Call LoadIfNecessary() in CWVWebView session restore. > > The web view load scheduled by WKBasedNavigationManager::Restore() is > deferred when used in CWVWebView's |resetWebStateWithSessionStorage| > because the |_containerView| is not created until later. This CL calls > LoadIfNecessary() explicitly after the view is created to trigger the > session restoration. > > This fixes WebViewRestorableStateTest when WKBasedNavigationManger is > enabled. A better approach would be to turn this test into a > programmatic test so both navigation managers implementations are > tested, but web::features symbols are not exposed in ios/web_view. > > Bug: 862714 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:ios-simulator-cronet > Change-Id: I21e694e3fef6a833f1cce04ff9cebd3784349111 > Reviewed-on: https://chromium-review.googlesource.com/c/1135435 > Commit-Queue: Danyao Wang <danyao@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org> > Reviewed-by: Justin Cohen <justincohen@chromium.org> > Auto-Submit: Danyao Wang <danyao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#626170} Bug: 862714 Change-Id: I853a8e030bef9f812605eac24c65d8237027f107 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;luci.chromium.try:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/c/1437574 Reviewed-by: Justin Cohen <justincohen@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#626206}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .