Block or allow all MIDI using the existing SysEx permission We have changed our approach for gating all MIDI access behind a permission prompt. Now, the existing SysEx permission and prompt will be used to control all access to the Web MIDI API. This CL does the following: - Roll back registration of the basic MIDI content setting and request type - Move the feature flag location from content/public/common to thrid_party/blink/public/common, since the feature is no longer related to content - Update test_driver tests (including WPTs) to request the permission with the SysEx flag set to true - Always show the SysEx version of the prompt by modifying midi_access_initializer.cc Note that one external WPT is also being updated. Although other browsers may not need the sysex flag set to true for the idlharness tests to pass, setting it to true should not cause the tests to fail since it is stronger than the basic midi permission as per spec: https://webaudio.github.io/web-midi-api/#permissions-integration Bug: 1420307 Change-Id: I5a6c45641c440f34bfdba0fb2076ae030528c634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5154368 Reviewed-by: Ravjit Uppal <ravjit@chromium.org> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Reviewed-by: Sina Firoozabadi <sinafirooz@chromium.org> Commit-Queue: Michael Wilson <mjwilson@chromium.org> Reviewed-by: Hongchan Choi <hongchan@chromium.org> Reviewed-by: Charlie Reis <creis@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/main@{#1270342}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.