commit 44d62a1ac56d81dcdd5f324eebf16d76e20c926f
author Dan McArdle <dmcardle@chromium.org> Thu Feb 29 17:08:14 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Thu Feb 29 17:08:14 2024
tree 43374ec30e6846d0a47403250643a40467f67819
parent 193ad29060f12c3283b88545346b6eaff626a81d

SQL: Make sql::Transaction hold WeakPtr<Database>

Now, Transaction checks whether the Database has been destroyed before
using it.

This CL also adds stricter sequence checking to Database, which found a
few places that Database was passed between sequences:

(1) storage::DatabaseTracker was using and destroying sql::Database on
    different sequences. Now, it simply destroys the Database instance
    in storage::DatabaseTracker::Shutdown(), which already runs on the
    correct sequence.

(1) history::InMemoryDatabase was "slurping" data from disk on one
    sequence, then querying the data on a different sequence. To support
    this use case, we added added sql:Database::DetachFromSequence().
    Now, InMemoryDatabase effectively annotates the cut point where the
    Database is handed off to another sequence.

Bug: 326498393
Change-Id: I866061feaf08d48607d97731a512bc02ce497f71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5320373
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Auto-Submit: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1267047}