Google Git
Sign in
chromium / chromium / src / 44e65b0018ff1aa9f55276c3db0027be55827355
commit44e65b0018ff1aa9f55276c3db0027be55827355[log] [tgz]
authorFabio Tirelo <ftirelo@chromium.org>Wed Feb 12 16:38:38 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Feb 12 16:38:38 2025
tree5f33dbbdeeaa216a3b5be957e0cd539fffdb296d
parent0975e56cebaa0672b18eadcda5da2a536fe5a22d [diff]
[Omnibox] Re-add call to LogSearchEngineUsed

The call to LogSearchEngineUsed was accidentally removed in
http://crrev.com/c/6136780, and we missed that during code review due
to lack of test coverage on that line.

This CL re-adds the call to the function and add proper test coverage
to avoid regressions.

Given how importance of Search client metrics, I think metrics testing
deserves its own browser test, which is also introduced in this CL.
This CL starts small and only adds tests for LogSearchEngineUsed, but
I think we should eventually make sure that module exercises at least
the most relevant metrics collected client-side.

Alternatively, we could have added those tests to existing browser
tests (e.g. omnibox_view_browsertest.cc), but those already have a
very clear goal of testing different interactions with the Omnibox, so
keeping those separate seemed to be the best option for now.

Bug: 395882994
Fixed: 395882994
Change-Id: I3e72bbd34f422101f7ed4379f5aa1478077e3ce7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6254219
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1419335}
3 files changed
tree: 5f33dbbdeeaa216a3b5be957e0cd539fffdb296d
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.