[Windows] Fix error return from RunDeElevated On error, base::win::RunDeElevated was returning an invalid base::Process and relying on the Windows last error code being useful to callers. While cleaning up the callstack on exit, it just so happens that privilege restoration (specifically, the call eventually made to LookupPrivilegeValue) was overwriting the error code with ERROR_SUCCESS. To mitigate this, we change the result of RunDeElevated to base::expected so that the error code is explicitly returned by the function in case of error. Bug: none Change-Id: Icc2b15990eab3f9f9365199851d53638c2ae559f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6678731 Commit-Queue: S Ganesh <ganesh@chromium.org> Reviewed-by: S Ganesh <ganesh@chromium.org> Auto-Submit: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/main@{#1479336}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.