Google Git
Sign in
chromium / chromium / src / 450acce3eaefadd35d19d1d11ba9f1ee7ded38db
commit450acce3eaefadd35d19d1d11ba9f1ee7ded38db[log] [tgz]
authorSophie Wen <sophiewen@chromium.org>Thu Nov 30 03:18:47 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Thu Nov 30 03:18:47 2023
tree56da2d0205ff91ee03ea63f2338d65b357db6e9b
parent6a194c0463b4a61f20fed69fc91b8c02d73e0a9c [diff]
snap-groups: Move bounds calculations to split_view_utils

This refactors snapped bounds calculations from SplitViewController to
`split_view_utils::CalculateSnappedWindowBoundsInScreen()`. This is
needed for SnapGroups, to get the snapped bounds independent of
`SplitViewController::split_view_divider_`, since each SnapGroup will
have its own divider. Each SnapGroup will pass its divider's divider
position and divider width to `CalculateSnappedWindowBoundsInScreen()`.

Also moves other util functions to split_view_utils.

Test: existing
Fixed: b/296935443
Change-Id: Icad60732061a9fb99cada419dcc1be5bfac9a833
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5063361
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Sophie Wen <sophiewen@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1231113}
17 files changed
tree: 56da2d0205ff91ee03ea63f2338d65b357db6e9b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitattributes
  63. .gitignore
  64. .gitmodules
  65. .gn
  66. .mailmap
  67. .rustfmt.toml
  68. .vpython3
  69. .yapfignore
  70. ATL_OWNERS
  71. AUTHORS
  72. BUILD.gn
  73. CODE_OF_CONDUCT.md
  74. codereview.settings
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.