Google Git
Sign in
chromium / chromium / src / 4544486ef38b1e84e6c8d144541446527b212638
commit4544486ef38b1e84e6c8d144541446527b212638[log] [tgz]
authorScott Violet <sky@chromium.org>Fri Feb 03 18:28:12 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Feb 03 18:28:12 2023
treeb7d83c0e2db028f3bf2844707d3dda68e525ab50
parent58e24a12a58e9e641f118941d92cd5ac5ebab997 [diff]
content: updates direct_sockets_test_utils to use ShellContentBrowserClient

Tests using IsolatedWebAppContentBrowserClient install it as the
ContentBrowserClient. ContentBrowserClient may be used at random
points for necessary functionality, such as registering mojo
interfaces. If this functionality is not there, the renderer may
be killed, leading to flake. This patch changes
IsolatedWebAppContentBrowserClient to subclass
ShellContentBrowserClient.

There's a couple of other changes here:
. Updates ShellContentBrowserClient so that more than once instance
  can be created
. Moves direct_sockets_test_utils from test_support target to
  content_browsertests target. direct_sockets_test_utils now depends
  upon ShellContentBrowserClient. The target containing
  ShellContentBrowserClient depends upon test_support, so
  direct_sockets_test_utils needs to move (otherwise we end up with
  a cycle).

Bug: 1406282

Change-Id: Id7b676e352ed469d82084ebbefb3aa3d5e908cbd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4214276
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1101093}
4 files changed
tree: b7d83c0e2db028f3bf2844707d3dda68e525ab50
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.