commit | 4587be2905262a8f0d2c151336b3416a01ffbfc4 | [log] [tgz] |
---|---|---|
author | Andreu Botella <abotella@igalia.com> | Mon Apr 15 12:38:51 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Apr 15 12:38:51 2024 |
tree | e1cfc81860655a31da0bb27f86ce0a1bb823f11a | |
parent | c6aa85487a9ca39902964f764854e6a072f77a29 [diff] |
[line-clamp] Make `line-clamp` create a new BFC Although `-webkit-line-clamp` has always created an independent formatting context, our prototype implementation of `line-clamp` initially made it so the `line-clamp` property (but not `-webkit-line-clamp`) didn't necessarily create one. However, in the course of implementing this proposal, the fact that it did not necessarily create a new BFC raised issues, such as how nested line-clamps should work, or how floats inside a line-clamp container should affect floats outside it. These problems go away by having line-clamp create a new BFC, and this CL takes that route. This patch also removes `BlockLineClampData::is_original_line_clamp_context`, which was needed to be able to distinguish whether `(-webkit-)line-clamp` was specified on the current block element, or whether it inherited its line clamp data from its parent. With this change, checking if the current block is a new BFC is enough. Bug: 40336192 Change-Id: I8a16ec18ce1653caaf1c7d06280a2a7e4604a946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5453431 Commit-Queue: Andreu Botella <abotella@igalia.com> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1287280}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.