[line-clamp] Make `line-clamp` create a new BFC

Although `-webkit-line-clamp` has always created an independent
formatting context, our prototype implementation of `line-clamp`
initially made it so the `line-clamp` property (but not
`-webkit-line-clamp`) didn't necessarily create one.

However, in the course of implementing this proposal, the fact that it
did not necessarily create a new BFC raised issues, such as how nested
line-clamps should work, or how floats inside a line-clamp container
should affect floats outside it. These problems go away by having
line-clamp create a new BFC, and this CL takes that route.

This patch also removes
`BlockLineClampData::is_original_line_clamp_context`, which was needed
to be able to distinguish whether `(-webkit-)line-clamp` was specified
on the current block element, or whether it inherited its line clamp
data from its parent. With this change, checking if the current block
is a new BFC is enough.

Bug: 40336192
Change-Id: I8a16ec18ce1653caaf1c7d06280a2a7e4604a946
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5453431
Commit-Queue: Andreu Botella <abotella@igalia.com>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1287280}
9 files changed
tree: e1cfc81860655a31da0bb27f86ce0a1bb823f11a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. .clang-format
  52. .clang-tidy
  53. .clangd
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  67. BUILD.gn
  69. codereview.settings
  70. CPPLINT.cfg
  71. DEPS
  74. LICENSE.chromium_os
  75. OWNERS
  76. PRESUBMIT.py
  77. PRESUBMIT_test.py
  78. PRESUBMIT_test_mocks.py
  79. README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.