Google Git
Sign in
chromium / chromium / src / 45b258ef29083938d08841b64b5514f27bf94bac
commit45b258ef29083938d08841b64b5514f27bf94bac[log] [tgz]
authorDavid Song <wintermelons@google.com>Tue Oct 26 23:24:52 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Oct 26 23:24:52 2021
treef7b9b284e350bf234b6376a0bed365da44767502
parentb3de44cfc9c805565f6b125c11e8ba94001c725b [diff]
[fuchsia] Implement SetContentAreaSettings in Frame FIDL API.

Corresponding FIDL API change is in https://fxrev.dev/590185

The `SetContentAreaSettings` API merges existing APIs like
`SetPreferredTheme` and `SetPageScale`. We will deprecate the
`SetPreferredTheme` API in this CL. `autoplay_policy` was previously
set on Frame initialization in `CreateFrameParams` is also moved to
`SetContentAreaSettings`.

- Changed `CreateFrameForWebContents` to return a pointer to the newly
created Frame, and nullptr if a Frame could not be created.
- Changed `SetWebPreferences` calls to be done through the Frame using
`SetContentAreaSettings` API instead.
- Improved consistency of `WebPreferences` when it is recomputed by
Content layer.
- Changed `FromWebContents` to return nullptr if web_contents is not
yet owned by a Frame. Added `DCHECK` to callers to ensure previous
invariant.
- Added browser tests for `SetContentAreaSettings` API.
- Improved error handling in `ThemeManager`.
- Hide scrollbars in Cast Component.


Bug: 1254073
Change-Id: I31c8e374b58cd3a4bb324ab3abb30bc3818e17da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3205636
Commit-Queue: David Song <wintermelons@google.com>
Auto-Submit: David Song <wintermelons@google.com>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/main@{#935191}
13 files changed
tree: f7b9b284e350bf234b6376a0bed365da44767502
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython
  63. .vpython3
  64. .yapfignore
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. DEPS
  70. DIR_METADATA
  71. ENG_REVIEW_OWNERS
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.