Google Git
Sign in
chromium / chromium / src / 45c0029def3706a9b37b9fc5b0e83386749a10c1
commit45c0029def3706a9b37b9fc5b0e83386749a10c1[log] [tgz]
authorJohn Chen <johnchen@chromium.org>Wed Dec 20 20:42:37 2017
committerCommit Bot <commit-bot@chromium.org>Wed Dec 20 20:42:37 2017
treec889040f87dda94b77d74dc1ffaaf292d6a4ca2a
parent369fae2d336df5c39ecf26e9f896e54ab1e2bdbf [diff]
[ChromeDriver] Fix ExecuteScript when script returns no result

V8 CL https://crrev.com/c/834669 changed the behavior of the JavaScript
engine. When it evaluates a script that returns no result, the result
object no longer contains a 'value' property, while previously, the
result contained a 'value' property with a value of null. After this CL
was merged into Chromium as https://crrev.com/525272, ChromeDriver
generates an error when it can't find the 'value' property.

This CL modifies ChromeDriver to recognize that 'value' is optional.

Bug: chromedriver:2191
Change-Id: I3cf65fb5824c161f3b1b0d982884d070a4a76b41
Reviewed-on: https://chromium-review.googlesource.com/837488
Reviewed-by: Jonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#525440}
1 file changed
tree: c889040f87dda94b77d74dc1ffaaf292d6a4ca2a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. blink/
  6. build/
  7. build_overrides/
  8. cc/
  9. chrome/
  10. chrome_elf/
  11. chromecast/
  12. chromeos/
  13. cloud_print/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .