Google Git
Sign in
chromium / chromium / src / 45e34cdf0389ae5d1048c135d509236e1c951d75
commit45e34cdf0389ae5d1048c135d509236e1c951d75[log] [tgz]
authorconniekxu <conniekxu@chromium.org>Mon May 16 18:06:52 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon May 16 18:06:52 2022
tree2c315ffab78d5c00425d71483bacc2ecf2548516
parent0dfb733a7a6ae99a60c68c8010ba977b0a277ff4 [diff]
[Merge to M-103]capture_mode: Make select capture region work properly

This CL fixed the issue that capture region is not selectable nor
draggable after start pressing on the capture bar or settings and then
release the press outsiede of it. To fix it, we should let the event
targeted on the capture bar or settings go through and to be handled
by it instead of setting the event as handled and stopping propagation.

(cherry picked from commit 7674929cec1d1876aee6ab235f946dad6442a7d2)

Test: Manual, added a regression test
Change-Id: I8f5fbbd30d95f0fd520a67a32fcac5c9a04f9869
Fixed: 1325028
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3645696
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1002973}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3648909
Commit-Queue: Connie Xu <conniekxu@chromium.org>
Cr-Commit-Position: refs/branch-heads/5060@{#18}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
3 files changed
tree: 2c315ffab78d5c00425d71483bacc2ecf2548516
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.