[base] Watch for hangs from wake-up to idle.

As opposed to only during a work item. This means watching the message
pump's overhead as a "work item".

And also now watch the end of a task which caused a nested loop.

Furthermore, move the conditional HangWatcher::IsEnabled() logic to
hang_watcher.cc (initially with the intent of allowing
ThreadControllerWithMessagePumpImpl to DCHECK(hang_watch_scope_) in a
few places but turns out none can, added comments to that affect). Kept
this nonetheless and moved the default timeout so that a simple
emplace() can be used to reset the scope.

Also removes the superfluous BeginWorkItem() in DoIdleWork() This was
not a task and that call would make it look like one under
https://chromium-review.googlesource.com/c/chromium/src/+/3687380 Its
presence was the only thing that made the DCHECK(!hang_watch_scope_) at
the end of ThreadControllerWithMessagePumpImpl::Run() pass (as its
OnEndWorkItem() cleared the scope). It didn't however mean that the
scopes were well matched since OnBeginWorkItem overrides prior scopes.

OnSystemIdle() is now being watched as part of the last HangWatchScope
before the end of DoIdleWork().

Bug: 1329717, 1034046
Change-Id: Ic4550a8e5ac2ace9da8c9e1f7f4a22cf2e38f941
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3686243
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Olivier Li <olivierli@chromium.org>
Reviewed-by: Etienne Bergeron <etienneb@chromium.org>
Reviewed-by: Francois Pierre Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1013676}
5 files changed
tree: 14bf594ca43c44f260ce0f208006cbdd5ea4b138
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.