commit | 468e46f82583b18b51a94582ef90e0c98797f38f | [log] [tgz] |
---|---|---|
author | Gabriel Charette <gab@chromium.org> | Mon Jun 13 22:00:54 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Mon Jun 13 22:00:54 2022 |
tree | 14bf594ca43c44f260ce0f208006cbdd5ea4b138 | |
parent | 2f0642124e57e0fc03cfaf06365e00198b0c5544 [diff] |
[base] Watch for hangs from wake-up to idle. As opposed to only during a work item. This means watching the message pump's overhead as a "work item". And also now watch the end of a task which caused a nested loop. Furthermore, move the conditional HangWatcher::IsEnabled() logic to hang_watcher.cc (initially with the intent of allowing ThreadControllerWithMessagePumpImpl to DCHECK(hang_watch_scope_) in a few places but turns out none can, added comments to that affect). Kept this nonetheless and moved the default timeout so that a simple emplace() can be used to reset the scope. Also removes the superfluous BeginWorkItem() in DoIdleWork() This was not a task and that call would make it look like one under https://chromium-review.googlesource.com/c/chromium/src/+/3687380 Its presence was the only thing that made the DCHECK(!hang_watch_scope_) at the end of ThreadControllerWithMessagePumpImpl::Run() pass (as its OnEndWorkItem() cleared the scope). It didn't however mean that the scopes were well matched since OnBeginWorkItem overrides prior scopes. OnSystemIdle() is now being watched as part of the last HangWatchScope before the end of DoIdleWork(). Bug: 1329717, 1034046 Change-Id: Ic4550a8e5ac2ace9da8c9e1f7f4a22cf2e38f941 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3686243 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by: Olivier Li <olivierli@chromium.org> Reviewed-by: Etienne Bergeron <etienneb@chromium.org> Reviewed-by: Francois Pierre Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/main@{#1013676}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.