Google Git
Sign in
chromium / chromium / src / 4690e9018a6acc2aaae23d7f35e7802d078eb0a0
commit4690e9018a6acc2aaae23d7f35e7802d078eb0a0[log] [tgz]
authorRobbie Gibson <rkgibson@google.com>Tue Nov 05 16:32:14 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Nov 05 16:32:14 2024
tree21db20d51b52b96814e51d962cb259eadc38b4db
parent26cfeb9359a6843f20f30c3785eca1b226ceed10 [diff]
Reland "[ntp] Add interactive UI test for NTP mobile promo"

This is a reland of commit b51bb0374ea679ad0355a47457207809006fad91

The original CL waited for the elements to load, but there may be some
rendering delay (e.g. transitions), which cause further interactions
to fail. This new CL now waits for the elements to render on the page,
which should fix the flakes in the original CL.

Original change's description:
> [ntp] Add interactive UI test for NTP mobile promo
>
> Bug: 376291361
> Change-Id: Ia68f3e72dcc5bdfbe95d29bf86e0b4f03ba5819f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5972982
> Reviewed-by: Paul Adedeji <pauladedeji@google.com>
> Commit-Queue: Robbie Gibson <rkgibson@google.com>
> Cr-Commit-Position: refs/heads/main@{#1377141}

Bug: 376291361
Change-Id: Ic81d6a9473e551a6b1dbac7087f0615d4c4eb6fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5988990
Reviewed-by: Paul Adedeji <pauladedeji@google.com>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/main@{#1378375}
2 files changed
tree: 21db20d51b52b96814e51d962cb259eadc38b4db
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.