Google Git
Sign in
chromium / chromium / src / 46a44f06a672642f222789dd174c17d7c0121fbe
commit46a44f06a672642f222789dd174c17d7c0121fbe[log] [tgz]
authorSteven Holte <holte@google.com>Tue Mar 12 03:07:32 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Mar 12 03:07:32 2024
tree52f436dfb92ad9472374a1539ba0368d7e9c163a
parent0c09498c0f663c7abe422a0ee55c4ae6bde43d49 [diff]
Fix LAST_RESORT_SUGGESTION annotation on metrics owners.

This should make gerrit prefer to suggest other owners (either chromium-metrics-review@google.com, or a more specific alias).

The annotation only works on lines assigning directly to users.
https://chromium-review.googlesource.com/plugins/code-owners/Documentation/backend-find-owners.html#lastResortSuggestion

Instead
* Move current owners to a  METRICS_OWNERS file and annotate all of them LAST_RESORT_SUGGESTION
* Suggest the alias instead in base/metrics/OWNERS
  * Reference that when it's "metrics infrastructure".
* Reference METRICS_OWNERS directly for metrics reviews, which should also set more specific owners and "noparent".

Change-Id: I6a9c49dc350ca8084b12abc94b120ffb54c8b3fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5352544
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1271342}
8 files changed
tree: 52f436dfb92ad9472374a1539ba0368d7e9c163a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.