commit 46bb8351341436f1b058bec804c7904acce15fff
author Benjamin Beaudry <bebeaudr@microsoft.com> Mon Jan 13 18:38:21 2020
committer Commit Bot <commit-bot@chromium.org> Mon Jan 13 18:38:21 2020
tree 0d48616e8ff422fcab9006bff735603f3c405a91
parent d83311b3965c24d1c80460089bed3a5889dd9c69

Fix IValueProvider::IsReadOnly for non-editable controls

When AXPlatformNodeWin::get_IsReadOnly() was called on links and other
non-editable controls, it used to return false. It was only looking at
a readonly or disabled restriction, but some controls are expected to
be readonly even without this explicit restriction.

This CL updates the condition used to determine if the control is
readonly by looking at the state, the role and other attributes of the
node.

While I'm here, I also took the liberty to update the usage we made of
|ax::mojom::Restriction::kReadonly| in multiple places and replace it
by AXNodeData::IsReadonlyOrDisabled() which defines the returned value
based on many conditions.

To know if a node is readonly or disabled, we should now always refer
to AXNodeData::IsReadonlyOrDisabled() instead of only looking at the
restriction.

Bug: 928948
Change-Id: Ica3176643b129329d15d38c9698d65af69448d75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960715
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com>
Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#730652}