[iOS]Restart signin coordinator only if needed

Due to a bug in UIKit up to iOS18, the Add Account view may disappear
without calling its callback. Furthermore, many coordinators can
directly open the add account (or reauth) view on top of
self.baseViewController. This mean that, when we end-up with a request
to start a sign-in coordinator (directly or indirectly) and a sign-in
coordinator is already started, it’s impossible to know whether this is
a double tap and the request should be ignored. Or whether the view
disappeared silently, and so the previous coordinator should be stopped
and a new one started.

Stopping and restarting is generally speaking a bad idea, as it may mean
interrupting the user during an authentication in progress, or even
having UIKit warns that we should not have done UI change before the
previous UI was change was done. So this CL ensure that the already
started coordinator is stopped in case of doubt. And if the program can
be certain that the view is still displayed, the request for a new
coordinator is simply ignored.

This CL introduce the method `ShouldStartANewCoordinator` that informs,
depending on the value assigned currently to the coordinator variable
whether a new coordinator should be started. This allows to simplify
both the content of the `if` and the place where the logic for the early
return is explained.

In order to do so, it also introduces a protocol that informs whether
the coordinator can have this bug. This protocol will become even more
useful when more coordinators stops inheriting from SigninCoordinator.

Bug: 395959814
Change-Id: I6b89c836142ab905c4d76fd6a6cfdae02426fd07
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6818278
Commit-Queue: Mark Cogan <marq@chromium.org>
Auto-Submit: Arthur Milchior <arthurmilchior@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1503385}
20 files changed
tree: 747bc61e1c0a348ca49d0208d99bb53feed8332e
  1. .gemini/
  2. .github/
  3. agents/
  4. android_webview/
  5. apps/
  6. ash/
  7. base/
  8. build/
  9. build_overrides/
  10. buildtools/
  11. cc/
  12. chrome/
  13. chromecast/
  14. chromeos/
  15. codelabs/
  16. components/
  17. content/
  18. crypto/
  19. dbus/
  20. device/
  21. docs/
  22. extensions/
  23. fuchsia_web/
  24. gin/
  25. google_apis/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. net/
  34. pdf/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .cursorignore
  54. .geminiignore
  55. .git-blame-ignore-revs
  56. .gitallowed
  57. .gitattributes
  58. .gitignore
  59. .gitmodules
  60. .gn
  61. .mailmap
  62. .rustfmt.toml
  63. .vpython3
  64. .yapfignore
  65. ATL_OWNERS
  66. AUTHORS
  67. BUILD.gn
  68. CODE_OF_CONDUCT.md
  69. codereview.settings
  70. CPPLINT.cfg
  71. CRYPTO_OWNERS
  72. DEPS
  73. DIR_METADATA
  74. LICENSE
  75. LICENSE.chromium_os
  76. OWNERS
  77. PRESUBMIT.py
  78. PRESUBMIT_test.py
  79. PRESUBMIT_test_mocks.py
  80. README.md
  81. SECURITY_OWNERS
  82. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.