commit 470b1f55df1f7440e62266b3addcf97d49c92a4c
author Louis Romero <lpromero@google.com> Mon Mar 25 16:06:20 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Mon Mar 25 16:06:20 2024
tree c9e7e4082e84e421276a21d187f5a48533e33757
parent 1fb028b68063585fde15ef300df131a7c0fdc0f2

Add DWC to TabSwitcherItem

Light TabSwitcherItems (i.e. only created via a WebStateID) should not
be asked to fetch a snapshot or favicon (outside of tests).
To make sure we don't have such instances, I add DumpWithoutCrash calls
that we'll monitor via crbug.com/331159004 and remove in a future
milestone if all goes well.

Bug: 331158823
Change-Id: I2eca19605ac50fb74502cce019982425ba161e61
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5391306
Commit-Queue: Louis Romero <lpromero@google.com>
Auto-Submit: Louis Romero <lpromero@google.com>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1277686}

ios/chrome/browser/ui/tab_switcher/tab_switcher_item.mm

diff --git a/ios/chrome/browser/ui/tab_switcher/tab_switcher_item.mm b/ios/chrome/browser/ui/tab_switcher/tab_switcher_item.mm
index 70975de..5d423dc 100644
--- a/ios/chrome/browser/ui/tab_switcher/tab_switcher_item.mm
+++ b/ios/chrome/browser/ui/tab_switcher/tab_switcher_item.mm
@@ -5,6 +5,7 @@
 #import "ios/chrome/browser/ui/tab_switcher/tab_switcher_item.h"
 
 #import "base/check.h"
+#import "base/debug/dump_without_crashing.h"
 #import "ios/web/public/web_state_id.h"
 #import "url/gurl.h"
 
@@ -31,11 +32,21 @@
 - (void)fetchFavicon:(TabSwitcherImageFetchingCompletionBlock)completion {
   // Subclasses should override this method. It is OK not to call super.
   completion(self, nil);
+  // This should not be called in production, as only real
+  // WebStateTabSwitcherItem should be asked to fetch a favicon.
+  // TODO(crbug.com/331159004): Remove in a later milestone if we don't receive
+  // any.
+  base::debug::DumpWithoutCrashing();
 }
 
 - (void)fetchSnapshot:(TabSwitcherImageFetchingCompletionBlock)completion {
   // Subclasses should override this method. It is OK not to call super.
   completion(self, nil);
+  // This should not be called in production, as only real
+  // WebStateTabSwitcherItem should be asked to fetch a snapshot.
+  // TODO(crbug.com/331159004): Remove in a later milestone if we don't receive
+  // any.
+  base::debug::DumpWithoutCrashing();
 }
 
 - (void)prefetchSnapshot {