[ntp] Make sure only one promo type is displayed during NTP's lifecycle.

1. Prevents the mobile promo from showing if the default promo
has already been displayed, and vice versa.
2. Ensures that `middle_slot_promo.ts` doesn't fire
`ntp-middle-slot-promo-loaded` until a promo has rendered.
Before this change, mobile promos could render after the
event was fired, potentially causing a flicker [1].

[1]https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/resources/new_tab_page/app.ts;drc=2832d166ea1a726ba4795c43e07f841d56d00037;l=237

Change-Id: Ia051e6ca3965e3b93b6a4a76ebee81249c2a324f
Bug: 372923104
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5926133
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Commit-Queue: Paul Adedeji <pauladedeji@google.com>
Auto-Submit: Paul Adedeji <pauladedeji@google.com>
Cr-Commit-Position: refs/heads/main@{#1367878}
2 files changed
tree: a91ce9b0cd521be945bf16c62182cbf7ccfda313
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. google_update/
  24. gpu/
  25. headless/
  26. infra/
  27. ios/
  28. ipc/
  29. media/
  30. mojo/
  31. native_client_sdk/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .git-blame-ignore-revs
  54. .gitallowed
  55. .gitattributes
  56. .gitignore
  57. .gitmodules
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython3
  62. .yapfignore
  63. ATL_OWNERS
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. CPPLINT.cfg
  69. CRYPTO_OWNERS
  70. DEPS
  71. DIR_METADATA
  72. LICENSE
  73. LICENSE.chromium_os
  74. OWNERS
  75. PRESUBMIT.py
  76. PRESUBMIT_test.py
  77. PRESUBMIT_test_mocks.py
  78. README.md
  79. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.