commit 47153816a67500ef6f5955fa3f81e703652438a9
author Scott Violet <sky@chromium.org> Tue Nov 28 00:19:24 2023
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Tue Nov 28 00:19:24 2023
tree 12fda76f84afcb0aa7b4164b01e43601178626bd
parent 3e02d4e128fa6c2f2812a72e87791c22fc6b8e65

[reland 2] on-device: enables enable_ml_internal

Specifically for branded desktop builds.

The most recent reland was reverted because building with
build_with_internal_optimization_guide false and
enable_ml_internal true caused build problems. This reland
sets enable_ml_internal to true only if
build_with_internal_optimization_guide is true. For the time
being the two aren't always the same (chromeos/android). At
some point they should be compiled.


The original change was reverted because of compile issues with
win-arm and mac-intel. This disables the win-arm config (for the
moment). The mac-intel failure is twofold:
1. Some of the optimization-guide code is including tflite, and needs
   to inherit the gn config from neon_2_sse.
   Specifically the file neon_check.h has the include:
   This only works with the neon_2_sse config, which adds the right
   include dir.
2. With (1) fixed, NEON_2_SSE.h generates errors that require
   "-Wno-gnu-inline-cpp-without-extern." Disabling this is already
   in tflite_flags, but it really belongs in neon2 as that is the
   place with the issue.

The fix for 1&2 is only done for the standalone target as we don't
want to add public configs to targets that disable compiler warnings.


Bug b:308802463

Change-Id: Ib2d18808ee22835b824556d337b9a49f25d63665
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5064228
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1229635}