commit | 472297a091b35e91e270449e16e749822130e627 | [log] [tgz] |
---|---|---|
author | Fredrik Söderquist <fs@opera.com> | Thu Dec 01 09:58:33 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Dec 01 09:58:33 2022 |
tree | f4c1ca92951576116982b962175f84be4e5000ed | |
parent | df084322f09ca909686c21a8578e7cbcf03b0c6a [diff] |
Perform source selection when adding/remove an <img> to a <picture> When an <img> is removed from a <picture> parent, or when it is added to a <picture> parent, a source selection should take place, since these count as "relevant mutations" [1]. For the "insert" case, only <source> elements were considered previously. For the "remove" case no selection was trigger at all. Change the "insert" case to call SelectSourceURL(), and add handling in the "remove" case to do the same. In HTMLImageElement::RemovedFrom(), also move the unregistration of listeners from the <source>s to be symmetric with HTMLImageElement::InsertedInto() - i.e always do it if there is/was a <picture> parent. [1] https://html.spec.whatwg.org/multipage/embedded-content.html#the-img-element:html-element-insertion-steps Fixed: 1393688 Change-Id: I7dcab791c8bff71149ec449106f9e25519ff3706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4064460 Reviewed-by: Stephen Chenney <schenney@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/main@{#1077940}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.