Google Git
Sign in
chromium / chromium / src / 4732a83feb20b00b51a558a1e262c21c1944b984
commit4732a83feb20b00b51a558a1e262c21c1944b984[log] [tgz]
authorJoel Hockey <joelhockey@chromium.org>Wed Oct 30 00:25:16 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Oct 30 00:25:16 2024
tree66491f721c60169e1e01ab82c6e22a9622fbb3db
parentb6d85399424beced98bb8f92f03c6f3bf3f207c2 [diff]
Update android directory tests to include DocumentsProvider

When calling base::File::Stat() with a directory content-URI from a
DocumentsProvider, the call to OpenContentUri() in File() ctor will
fail since it is a dir rather than a file. This leaves the File object
in an invalid state, and ContentUriGetFileInfo() must be called since
it will not be called via file.GetInfo().

The code is currently ok in this regard and does not need changing, but
this updates the existing InMemoryContentProvider to be able to handle
DocumentContracts URIs and implement query() in order to act like a
DocumentsProvider for testing.

Fixes overflow bug when setting st_mtime_nsec in File::Stat().

Change-Id: I90f22bed219847d06272bb5a8a7a6d1e00308a3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5974375
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1375601}
6 files changed
tree: 66491f721c60169e1e01ab82c6e22a9622fbb3db
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.