Google Git
Sign in
chromium / chromium / src / 4781406d2e8e094ba35842db2625036d6f8885e6
commit4781406d2e8e094ba35842db2625036d6f8885e6[log] [tgz]
authorNoah Rose Ledesma <noahrose@google.com>Fri Nov 10 15:56:01 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Nov 10 15:56:01 2023
treeb988a04575b24fd6fe76c41eccb15010e90b6d3f
parent6f212d646eade5961a39cd8415d874fcc4652779 [diff]
Don't link the component updater into libsoda

The update client is defined as a static library rather than a
component. For various reasons, it would be difficult to refactor the
library to be a component. This has lead to a situation in which
updater client symbols are duplicated across different dynamic
libraries (e.g. libsoda & libchrome).

Typically, having duplicate symbols from different dynamic libraries
is not an issue, however duplicate Objective-C classes will cause a
log warning to be fired. We recently added a background downloader on
Mac which has Obj-C classes. The warning message fires very frequently
in component builds of Chrome, which is quite annoying.

To fix this, we would like to have libsoda not include this symbol. To
do so, we have separated the path definitions into a separate static
library for SODA to depend on.

Bug: 1493709
Change-Id: I48fddb1de3905144527f6898bfd8bfec482a8e6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5018461
Reviewed-by: Sorin Jianu <sorin@chromium.org>
Reviewed-by: Evan Liu <evliu@google.com>
Commit-Queue: Noah Rose Ledesma <noahrose@google.com>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1222950}
2 files changed
tree: b988a04575b24fd6fe76c41eccb15010e90b6d3f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .eslintrc.js
  60. .git-blame-ignore-revs
  61. .gitattributes
  62. .gitignore
  63. .gitmodules
  64. .gn
  65. .mailmap
  66. .rustfmt.toml
  67. .vpython3
  68. .yapfignore
  69. ATL_OWNERS
  70. AUTHORS
  71. BUILD.gn
  72. CODE_OF_CONDUCT.md
  73. codereview.settings
  74. DEPS
  75. DIR_METADATA
  76. LICENSE
  77. LICENSE.chromium_os
  78. OWNERS
  79. PRESUBMIT.py
  80. PRESUBMIT_test.py
  81. PRESUBMIT_test_mocks.py
  82. README.md
  83. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.