commit | 478b475aaa8e6b96f428ab034ea9fcd0a267f7f1 | [log] [tgz] |
---|---|---|
author | Justin Lulejian <jlulejian@chromium.org> | Thu Aug 01 01:33:28 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Thu Aug 01 01:33:28 2024 |
tree | 9f6343e46e9ac55b6745aa454f5f4c01e73a7dd9 | |
parent | a539c03e2ac242feafb921f7c1bdc01412f72393 [diff] |
[Extensions] Define a token to track running workers. Context: https://chromium-review.googlesource.com/c/chromium/src/+/5585864/comments/719d24c1_aff01013 In order to stop tracking running worker instances synchronously when they stop (ServiceWorkerTaskQueue::OnStopped()) we need to be able to uniquely identify the specific instance of running worker that has stopped. This has been done in //extensions as the combination of extension_id+version_id+render_process_id+thread_id, but it was suggested in the above comment to start using blink::ServiceWorkerToken in content::ServiceWorkerRunningInfo since it identifies the same thing. To completely replace our use of extension_id+version_id+render_process_id+thread_id will require a larger refactor in //extensions, but for now it'd be helpful to use it for ServiceWorkerTaskQueue::OnStopped(). So after this change, we will have access to it in WorkerId. Then in a follow-up CL we'll populate it when we create WorkerIds, and in another CL use it for comparison in ServiceWorkerTaskQueue::OnStopped(). Bug: 40936639 Change-Id: Ic69c05e1f0e36670e387cfeb45a1e1ddfdaa1f01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5743956 Auto-Submit: Justin Lulejian <jlulejian@chromium.org> Reviewed-by: Emilia Paz <emiliapaz@chromium.org> Commit-Queue: Emilia Paz <emiliapaz@chromium.org> Cr-Commit-Position: refs/heads/main@{#1335785}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.