Google Git
Sign in
chromium / chromium / src / 47c5e0ccad96eb9973259dfa4a72e0da327fa15d
commit47c5e0ccad96eb9973259dfa4a72e0da327fa15d[log] [tgz]
authorElaine Chien <elainechien@chromium.org>Mon Feb 07 18:50:36 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Mon Feb 07 18:50:36 2022
tree40b901cf239e4409c70adbee6b86920e316f4ece
parent918e8f755c77e50d99ac82d85fa6c3b91424f277 [diff]
[Color Pipeline] Replace GetThemeProviderForProfile with widget based
ThemeProvider in ChromeCustomizeThemesHandler.

VerifyThemeColors only tests that the developer called the color APIs
correctly. It calls the same function (GetAutogeneratedThemeColors) that
is called in ChromeCustomizeThemesHandler::GetChromeThemes or later down
the line in BrowserThemePack for ThemeProvider colors and simply
compares the results of effectively the same function call. On moving to
a widget based ThemeProvider we will not have a BrowserWindow in this
test setting and therefore will not have a ThemeProvider to test the
specific colors generated. Therefore this CL removes VerifyThemeColors
from the unit tests.

We will be able to remove the logic that returns a placeholder color
when we switch to ColorProvider since we will be guaranteed a
ColorProvider for WebContents.

Bug: 1056758
Change-Id: I2c761d04e89e26416069324e06796e4802847430
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3435147
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Elaine Chien <elainechien@chromium.org>
Cr-Commit-Position: refs/heads/main@{#967894}
2 files changed
tree: 40b901cf239e4409c70adbee6b86920e316f4ece
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.