Google Git
Sign in
chromium / chromium / src / 47d3a5ae43b6da9b51bcb67ea751c596a54c052b
commit47d3a5ae43b6da9b51bcb67ea751c596a54c052b[log] [tgz]
authorOrin Jaworski <orinj@google.com>Fri Apr 07 22:38:01 2023
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Apr 07 22:38:01 2023
treed6a3b13774d8abf4f1cb9f9d602d92db3ca9800b
parentcd5d59d7cf09a479768404450433e5965c023b8f [diff]
[omnibox][realbox] Make the Realbox a more real Omnibox with model, etc.

This CL overhauls the Realbox match and action taking mechanisms to make
use of a more complete model of the Omnibox. The AutocompleteController
is still fully driven by the Realbox, but now the OmniboxEditModel
and related interfaces are connected with the RealboxHandler. This
already eliminates a lot of code duplication, essentially trading for
some interface boilerplate that we may choose to implement when ready
to make the Realbox more feature complete.

Metrics reporting will be more complete and more consistent after this
change because the duplicate reporting code was removed and replaced
with direct calls to OmniboxEditModel::OpenSelection, the same single
code path used to commit the Omnibox everywhere else.

The AutocompleteController is now owned by the OmniboxEditModel
and is instantiated during construction instead of on first use.

Bug: 1408506
Change-Id: Iaa8e05a09b830a99d60ad6205a96d1c27928c3a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4405082
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Orin Jaworski <orinj@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1127813}
8 files changed
tree: d6a3b13774d8abf4f1cb9f9d602d92db3ca9800b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.