commit | 47d6367353cff1631f728a2a3a1f58f0f220d67b | [log] [tgz] |
---|---|---|
author | Jan Keitel <jkeitel@google.com> | Tue Jan 09 16:55:44 2024 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Jan 09 16:55:44 2024 |
tree | 3727396850a9bed745612283cc8c2f744dc2cf61 | |
parent | cb160f68039eb3a221511a63a224f3978f40ee4c [diff] |
Use ViewsTestBase in InkDropImpl test fixtures. This CL - Replaces testing::Test by ViewsTestBase as the base class for the test fixtures. Doing so allows a) getting rid of TestSimpleTaskRunner in favor of TaskEnvironment and b) provides an easy way of attaching the InkDropHostImpl to a Widget. The latter is the motivation behind this change: Currently, there is a single caller of View::SetNativeThemeForTesting, namely the RippleAndHighlightRecreatedOnHostThemeChange test. By attaching the InkDropHostImpl to a Widget, we can set the testing theme on the Widget instead and remove the method from the View. This will happen on a follow-up CL. - Inlines test fixtures methods and eliminates a test api member, since it can always be created on the fly. Bug: 1469136 Change-Id: If9b0bcf5d926d3cb58da6bfe88408482e8bb2f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5163631 Auto-Submit: Jan Keitel <jkeitel@google.com> Commit-Queue: Elly FJ <ellyjones@chromium.org> Reviewed-by: Elly FJ <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/main@{#1244725}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.