Ensure response_sender always runs for Smart Dim D-Bus

Previously, the D-Bus response_sender was not run for calls from powerd
to Ash's Smart Dim prediction service, under certain conditions
* Smart Dim disabled by policy
* Smart Dim request canceled (typically due to starting another one
  while the first was pending, which is expected to happen sometimes)

Sending a response_sender is now enforced by runtime CHECK().

This CL ensures response_sender is always invoked as follows, using a
default response of false (corresponding to "allow screen dim to
proceed"):

* For Smart Dim disabled by policy, a trivial short-circuit is used to
  return false.

* For canceled requests, the interface of SmartDimMlAgent is updated so
  that it passes an optional<ModelPrediction> to the client instead of a
  ModelPrediction. When an empty optional<> is returned thus, the client
  now invokes the callback to powerd with a default value of false. When
  a non-empty optional<> is provided, the pre-existing logic updating
  Smart Dim's internal state, logging, etc takes place as before.

Bug: chromium:406621242
Change-Id: I595868fbc83458876490ec546653e2302d1b44c1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6433508
Reviewed-by: Xinglong (Alan) Luan <alanlxl@chromium.org>
Commit-Queue: Andrew Moylan <amoylan@google.com>
Cr-Commit-Position: refs/heads/main@{#1443084}
5 files changed
tree: 22479cce4fb61dd20c0e7ba46b1015d7396ece9f
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. .clang-format
  50. .clang-tidy
  51. .clangd
  52. .git-blame-ignore-revs
  53. .gitallowed
  54. .gitattributes
  55. .gitignore
  56. .gitmodules
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. ATL_OWNERS
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. CPPLINT.cfg
  68. CRYPTO_OWNERS
  69. DEPS
  70. DIR_METADATA
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.