Google Git
Sign in
chromium / chromium / src / 47f5d9434eb58a7bc0862c2e92c7a6cd6d708c36
commit47f5d9434eb58a7bc0862c2e92c7a6cd6d708c36[log] [tgz]
authorAleksei Loshkarev <lixan@yandex-team.ru>Sat Jan 19 14:13:45 2019
committerCommit Bot <commit-bot@chromium.org>Sat Jan 19 14:13:45 2019
tree7cc5542eafc7f75a75ed81c70640fdc44255c761
parente92ccc00d7bbed2632e518d9d2b57edbff93d6d1 [diff]
Normalize Profile DoFinalInit sequence

Profiles are created by one of two ProfileManager functions:
CreateProfileHelper and CreateProfileAsyncHelper.

Also two DoFinalInit functions exists one in ProfileImpl
and one in ProfileManager.

In case of sync profile creation ProfileManager::DoFinalInit
is called after ProfileImpl::DoFinalInit. In case of async
profile creation ProfileManager::DoFinalInit is called
inside ProfileImpl::DoFinalInit through Profile::Delegate.

This CL moves delegate calls to end of ProfileImpl::DoFinalInit
and normalise profile initialization sequence.

In Yandex we have trouble with recently added
io_data_.InitializeDataReductionProxy()
because it was inserted after calling Profile::Delegate.

Change-Id: I3ca408e41ca13421d7899f66d5db8b8a06d77eb4
Reviewed-on: https://chromium-review.googlesource.com/c/1417874
Commit-Queue: Aleksei Loshkarev <lixan@yandex-team.ru>
Reviewed-by: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624471}
1 file changed
tree: 7cc5542eafc7f75a75ed81c70640fdc44255c761
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. cc/
  8. chrome/
  9. chrome_elf/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. jingle/
  31. mash/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. .clang-format
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .vpython
  59. AUTHORS
  60. BUILD.gn
  61. CODE_OF_CONDUCT.md
  62. codereview.settings
  63. DEPS
  64. ENG_REVIEW_OWNERS
  65. LICENSE
  66. LICENSE.chromium_os
  67. OWNERS
  68. PRESUBMIT.py
  69. PRESUBMIT_test.py
  70. PRESUBMIT_test_mocks.py
  71. README.md
  72. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .