Fix dir=auto traversal to not apply element-only rules to ancestors This fixes Chromium code to match half of the spec update in https://github.com/whatwg/html/issues/10488 and https://github.com/whatwg/html/pull/10561 . I previously thought the code was fine, but I realize a small update is needed. In particular, the code could apply element-only rules for dir=auto to elements (in particular, button-type inputs) that are auto-directionality form-associated elements but were not in the list of exclusions. This also fixes the list of exclusions to exclude specifically textarea, so that any actual text content of input elements (but not the value) is traversed as required by the spec. This also removes the no-longer needed is_deferred argument to ResolveAutoDirectionality. Bug: 576815, 352191350 Change-Id: I7c13b9661d23f8904727c8298a8dca6360d6d732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5798880 Commit-Queue: David Baron <dbaron@chromium.org> Reviewed-by: Di Zhang <dizhangg@chromium.org> Commit-Queue: Di Zhang <dizhangg@chromium.org> Cr-Commit-Position: refs/heads/main@{#1344402}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.