Google Git
Sign in
chromium / chromium / src / 482e518fcd554147d41e60dcc38bc0821fe15ab3
commit482e518fcd554147d41e60dcc38bc0821fe15ab3[log] [tgz]
authorMichele Fan <michelefan@chromium.org>Fri Apr 22 01:37:32 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Apr 22 01:37:32 2022
treed6055c9ff5f6d30c9b9c683d61547db265ec138b
parentc2f4ad33136a1d0142483790ec0876aee93eff43 [diff]
capture-mode: Revise tabbing through windows behavior in kWindow

Currently, windows that are minimized will still be focused while
tabbing through in kWindow capture source. Revise the tabbing through
behavior to ignore the windows.
Demo video: crbug.com/1309979#c11

Follow-up CL (crbug.com/1318231) :
Investigate on the algorithm to detect the occluded window. Add logic to
ignore windows that are occluded while tabbing through in kWindow.

Change-Id: Idb028011ddb41db74d0b0547cacce23cc11ecebf
Bug: 1309979
Test: Manually and added test
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3598095
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Michele Fan <michelefan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#995001}
6 files changed
tree: d6055c9ff5f6d30c9b9c683d61547db265ec138b
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython
  61. .vpython3
  62. .yapfignore
  63. AUTHORS
  64. BUILD.gn
  65. CODE_OF_CONDUCT.md
  66. codereview.settings
  67. DEPS
  68. DIR_METADATA
  69. ENG_REVIEW_OWNERS
  70. LICENSE
  71. LICENSE.chromium_os
  72. OWNERS
  73. PRESUBMIT.py
  74. PRESUBMIT_test.py
  75. PRESUBMIT_test_mocks.py
  76. README.md
  77. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.