[Extensions WebIDL] Support required callbacks using extended attributes This CL changes the WebIDL processor to mark returns_async fields as optional by default and allows them to be marked as required through the use of a new extended attribute 'requiredCallback'. Also adjusts existing tests to account for this and adds a new test for the new extended attribute. Also adds a TODO to clean some of this up in the future once we remove the context restrictions on promise based API calls. Background context: Generally callbacks are inheriently optional when calling an extension API function, as not including the callback will cause the function to instead return a promise for any asynchronous response. However we still carry the 'optionality' of the callback (returns_async) through the bindings for either 1) callers from contexts which do not support promise based calls (non-MV3/WebUI contexts) or 2) specific API functions which still do not support promise based calls (multi- parameter callbacks, etc.). Bug: 340297705 Change-Id: If46f43dcfb13c013133b69db5a5beeec8c4231e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6669174 Reviewed-by: Devlin Cronin <rdevlin.cronin@chromium.org> Commit-Queue: Tim <tjudkins@chromium.org> Cr-Commit-Position: refs/heads/main@{#1478258}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.