Google Git
Sign in
chromium / chromium / src / 4862b4da110b51f193b033d7943be47e15437bfc
commit4862b4da110b51f193b033d7943be47e15437bfc[log] [tgz]
authorAri Chivukula <arichiv@chromium.org>Wed Jul 24 20:59:34 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Jul 24 20:59:34 2024
treebe75a0bebae3f633dc5aadf2646bfe8708a7622a
parentd7cf668c6421a6c06192c61b73c73ded8be93f74 [diff]
[SAA] Fix remote disconnection issue with GC & handles

There's a bug where if the SAA handle falls out of scope, connections
between other objects (like Broadcast Channels) allocated from the
handle cease to work.
https://github.com/privacysandbox/privacy-sandbox-dev-support/issues/398

Let's add a test for the impacts of GC and transfer ownership of key
remotes/objects to a per-window-global to prevent disconnection issues.

I have confirmed this test crashes due to disconnection on trunk, and
succeeds here.

Fixed: 355018914
Change-Id: I1e760964a9927293b8a21565afe55360a100e8aa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5736256
Reviewed-by: Ben Kelly <wanderview@chromium.org>
Commit-Queue: Ayu Ishii <ayui@chromium.org>
Reviewed-by: Chris Fredrickson <cfredric@chromium.org>
Auto-Submit: Ari Chivukula <arichiv@chromium.org>
Reviewed-by: Ayu Ishii <ayui@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1332592}
10 files changed
tree: be75a0bebae3f633dc5aadf2646bfe8708a7622a
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.