Revert "Reland "Refactor TabHoverCardController to use a generic View."" This reverts commit 1129114ff6d93e48f1326275f715c31ec4aea4ca. Reason for revert: It's flaky after the reland Original change's description: > Reland "Refactor TabHoverCardController to use a generic View." > > This is a reland of commit f8249a1e06673b43d5ffe60a9b96d3bc54b2feea > > Original change's description: > > Refactor TabHoverCardController to use a generic View. > > > > Abstract HoverCardController logic so that other views can be used to > > show hovercards. Main changes include: > > > > * Introduce HoverCardDelegate that casts the View and provides data back to the controller > > * TabHoverCardController now no longer interacts with the view except for checking for equality and observing the tab thumbnail > > * Change interfaces to use View instead of Tab (e.g. UpdateHoverCard) > > * Rename 2 HoverCardUpdateTypes to reference View instead of Tab > > > > Bug: 439589464 > > Change-Id: I6b13c4ca5a44bfb0617001beb235bdd2af506d5a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6966297 > > Commit-Queue: Mickey Burks <mickeyburks@chromium.org> > > Reviewed-by: Darryl James <dljames@chromium.org> > > Reviewed-by: Eshwar Stalin <estalin@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1518923} > > Bug: 439589464 > Change-Id: Idb9bc0ac39858cc0c946963615221d251946f760 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6975271 > Reviewed-by: Eshwar Stalin <estalin@chromium.org> > Reviewed-by: Christopher Grant <cjgrant@chromium.org> > Commit-Queue: Mickey Burks <mickeyburks@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1520090} Bug: 439589464 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: I855e21c94cdc22ce0c4baaa447c93a16179dd944 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6981302 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Owners-Override: Mingyu Lei <leimy@chromium.org> Auto-Submit: Mingyu Lei <leimy@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1520379}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.