Google GitGoogle Git
Sign in
chromium/chromium/src/48a54b4c04fe1f5abe97d4ebe996eb69304d18d1
commit
48a54b4c04fe1f5abe97d4ebe996eb69304d18d1
[log]
author
Slobodan Pejic <slobodan@chromium.org>
Tue Jul 09 16:52:34 2024
committer
Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>
Tue Jul 09 16:52:34 2024
tree
f1e64ec35bdc07e798953697c3ddd7157e815060
parent
984625043be7e2c0fdaa8dea3c988e8dde5b62f1 [diff]
Show a checkmark when virtual card enrollment has completed.

Before this change when enrollment completes, the loading state
(activity indicator) stayed on the primary action button. Now, when
enrollment completes the activity indicator stops showing and is
replaced by a checkmark.

The checkmark image is used directly since the symbols utilities are
located in ios/chrome/browser/... which is not allowed by
ios/chrome/common/DEPS to be included in the confirmation alert view
controller.

The confirmation state (as well as the existing loading state) is
guarded by
autofill::features::kAutofillEnableVcnEnrollLoadingAndConfirmation.

Light mode mock:
https://screenshot.googleplex.com/7a56kAG7u9RC9mW.png

Light mode screenshot:
https://screenshot.googleplex.com/52izTTtWfvvyrYd.png

Dark mode screenshot:
https://screenshot.googleplex.com/6fu8ZieCZUCPW4f.png

Bug: 339887700, b/338625793
No-Presubmit: true
Change-Id: Ic0e1bdf0d7500e6997227a6d1b299cf8bbd89e96
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5666596
Reviewed-by: Kavita Soni <kavitasoni@chromium.org>
Commit-Queue: Kavita Soni <kavitasoni@chromium.org>
Auto-Submit: Slobodan Pejic <slobodan@chromium.org>
Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1324859}
7 files changed
tree: f1e64ec35bdc07e798953697c3ddd7157e815060
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. CPPLINT.cfg
  77. DEPS
  78. DIR_METADATA
  79. LICENSE
  80. LICENSE.chromium_os
  81. OWNERS
  82. PRESUBMIT.py
  83. PRESUBMIT_test.py
  84. PRESUBMIT_test_mocks.py
  85. README.md
  86. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.