Google Git
Sign in
chromium / chromium / src / 48a8d9a052dc7e7b96a37ded43752bcdc3b30163
commit48a8d9a052dc7e7b96a37ded43752bcdc3b30163[log] [tgz]
authorBenjamin Williams <bwwilliams@google.com>Wed May 18 01:33:41 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed May 18 01:33:41 2022
tree8a38b8fd34a4bfbdd3a625b4c367ca10992274bb
parentab0ba06ca03d1a1b426b649838a87e84502810d2 [diff]
Consolidate UMA RecordAction logic into the handler.

It's been discovered that crbug.com/3625259 merged code with improper
use of RecordAction(UmaActionForDestination(...)). Per the
documentation, these helper functions should be used with string
literals, whereas the merged CL uses a string variable.

This CL fixes this improper usage of
RecordAction(UmaActionForDestination(...)) by consolidating the existing
helper functions, UmaActionForDestination and UmaNameForDestination,
introduced by crbug.com/3644982 into a new function,
RecordUmaActionForDestination.

(cherry picked from commit 81c144ba9b976e90914584e880685d9a86f35006)

Change-Id: I671f054ce862c0e51a5225508d51f058bf89f19b
Bug: 1325615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3644982
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Benjamin Williams <bwwilliams@google.com>
Cr-Original-Commit-Position: refs/heads/main@{#1003836}
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3649958
Cr-Commit-Position: refs/branch-heads/5060@{#69}
Cr-Branched-From: b83393d0f4038aeaf67f970a024d8101df7348d1-refs/heads/main@{#1002911}
1 file changed
tree: 8a38b8fd34a4bfbdd3a625b4c367ca10992274bb
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia/
  22. fuchsia_webengine/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. media/
  32. mojo/
  33. native_client_sdk/
  34. net/
  35. pdf/
  36. ppapi/
  37. printing/
  38. remoting/
  39. rlz/
  40. sandbox/
  41. services/
  42. skia/
  43. sql/
  44. storage/
  45. styleguide/
  46. testing/
  47. third_party/
  48. tools/
  49. ui/
  50. url/
  51. weblayer/
  52. .clang-format
  53. .clang-tidy
  54. .eslintrc.js
  55. .git-blame-ignore-revs
  56. .gitattributes
  57. .gitignore
  58. .gn
  59. .mailmap
  60. .rustfmt.toml
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.