Google Git
Sign in
chromium / chromium / src / 48da0b6f1152c7084168c91c9272801194252847
commit48da0b6f1152c7084168c91c9272801194252847[log] [tgz]
authorAlex Ilin <alexilin@chromium.org>Wed May 14 10:25:57 2025
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed May 14 10:25:57 2025
treec195be3719a6e24eeed2ca3b21256719cce2a6ba
parent69a99d7532819962cf7d928cd759bcc181ad04ae [diff]
Revert "FSA: Only normalize the hardcoded rules once during initialization"

This reverts commit 37141c231485b178e8d9a6064916a1016311f207.

Reason for revert: ChromeFileSystemAccessPermissionContextSymbolicLinkCheckTest.ConfirmSensitiveEntryAccess_ResolveBlockPathSymbolicLink 
test starts failing. See https://crbug.com/417620032

Bug: 395595606, 417620032
Original change's description:
> FSA: Only normalize the hardcoded rules once during initialization
>
> Path normalization impacts the performance of the block rules check, and
> it was done for every block path for each check. In this CL, the path
> normalization for the hard coded rules will be done only once when
> initializing the `ChromeFileSystemAccessPermissionContext`.
>
> It's safe to keep a cache for the resolved paths since the path service
> should provide constant path results throughout a live session
> (https://source.chromium.org/chromium/chromium/src/+/main:base/path_service.h;l=39-40;drc=9d69367493326eeb650386198de90b220824702b)
>
> Manually tested that the block paths are set up with the same values
> with the main branch.
>
> Change-Id: Ia02d773640a5c44c6c55143efde28184243efd0c
> Bug: 395595606
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6428707
> Reviewed-by: Nathan Memmott <memmott@chromium.org>
> Commit-Queue: Mingyu Lei <leimy@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1456846}

Bug: 395595606, 417620032
Change-Id: Ifc6ea184597a371d5b0edfbd41b9866af107d874
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6544950
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Alex Ilin <alexilin@google.com>
Auto-Submit: Alex Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1459975}
3 files changed
tree: c195be3719a6e24eeed2ca3b21256719cce2a6ba
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. crypto/
  16. dbus/
  17. device/
  18. docs/
  19. extensions/
  20. fuchsia_web/
  21. gin/
  22. google_apis/
  23. gpu/
  24. headless/
  25. infra/
  26. ios/
  27. ipc/
  28. media/
  29. mojo/
  30. native_client_sdk/
  31. net/
  32. pdf/
  33. ppapi/
  34. printing/
  35. remoting/
  36. rlz/
  37. sandbox/
  38. services/
  39. skia/
  40. sql/
  41. storage/
  42. styleguide/
  43. testing/
  44. third_party/
  45. tools/
  46. ui/
  47. url/
  48. webkit/
  49. clank
  50. internal
  51. ios_internal
  52. native_client
  53. signing_keys
  54. v8
  55. .clang-format
  56. .clang-tidy
  57. .clangd
  58. .git-blame-ignore-revs
  59. .gitallowed
  60. .gitattributes
  61. .gitignore
  62. .gitmodules
  63. .gn
  64. .mailmap
  65. .rustfmt.toml
  66. .vpython3
  67. .yapfignore
  68. ATL_OWNERS
  69. AUTHORS
  70. BUILD.gn
  71. CODE_OF_CONDUCT.md
  72. codereview.settings
  73. CPPLINT.cfg
  74. CRYPTO_OWNERS
  75. DEPS
  76. DIR_METADATA
  77. LICENSE
  78. LICENSE.chromium_os
  79. OWNERS
  80. PRESUBMIT.py
  81. PRESUBMIT_test.py
  82. PRESUBMIT_test_mocks.py
  83. README.md
  84. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.