commit | 48e5509aec3cfd1173cd3da2a4ff954f41e19f31 | [log] [tgz] |
---|---|---|
author | luci-bisection@appspot.gserviceaccount.com <luci-bisection@appspot.gserviceaccount.com> | Fri Jan 10 03:39:20 2025 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Fri Jan 10 03:39:20 2025 |
tree | d6b094d52444c40699fcac534c9c44dfd6839c71 | |
parent | 022a6c135fc59bbb39dca1c425b987a2df63ad12 [diff] |
Revert "[WebAuthn] Make challengeUrl work on desktop" This reverts commit 53310dd7e09d71fa0dd0edea80dbe198e59aa46c. Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/6421507698851840 Sample build with failed test: https://ci.chromium.org/b/8726173297802392465 Affected test(s): [ninja://content/test:content_unittests/AuthenticatorImplTest.AppIdExcludeExtension](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fcontent%2Ftest:content_unittests%2FAuthenticatorImplTest.AppIdExcludeExtension?q=VHash%3Afc06801f1fa91dab) If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F6421507698851840&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F6090253&type=BUG Original change's description: > [WebAuthn] Make challengeUrl work on desktop > > This makes challengeUrl work on desktop Chrome, matching the behaviour > described in the current explainer: > https://github.com/w3c/webauthn/wiki/Explainer:-WebAuthn-challengeURL > > This is only enabled when the experimental web platform features flag is > turned on. > > Bug: 381219428 > Change-Id: I041dfd3297c34b8a87f620abbedfdea7a4896218 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6090253 > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Adam Langley <agl@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1404464} > Bug: 381219428 Change-Id: Idbe79fad13f5500a8e51d3749678ede1df5aff86 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6165113 Owners-Override: Adam Rice <ricea@google.com> Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/main@{#1404569}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure.
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.