commit 48fd44eb3959e1abd46624f7aa2611e43b589e00
author Anders Hartvoll Ruud <andruud@chromium.org> Fri Jul 09 12:39:14 2021
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Jul 09 12:39:14 2021
tree 6b67219ddea546991e156cc8287f34836185dba4
parent 286f0238ba16dcb5598a40551a634f853dd49b0a

Revert "Store base ComputedStyle on main ComputedStyle"

This reverts commit 4b03422f438df0087ae88aca943b1f55d133bbfa.

Reason for revert: Performance regressions, crbug.com/1227488

Original change's description:
> Store base ComputedStyle on main ComputedStyle
>
> Instead of storing the base ComputedStyle on ElementAnimations, this
> CL suggesting storing it on the (animated) ComputedStyle itself.
> Any animated ComputedStyle produced by StyleResolver gets an associated
> "StyleBaseData" object, which contains the base ComputedStyle and
> the base "important set".
>
> Even without other considerations, this appears to be far simpler to
> deal with than storing it "on the side", however, the true motivation
> for this change is related to container queries:
>
> Since container queries can run style recalc multiple times for the
> same element, we essentially pass through multiple style resolves where
> the "old style" (i.e. current style on the Element) changes each time.
> In other words, there can be multiple apparent "old styles" (some older
> than others). In order to deal with transitions correctly, it's
> necessary to get the *base style* of the *oldest* of the old styles
> (so to speak). Having to keep track of the "true old style" and
> "true old *base* style" separately exceeds my pain threshold. It seems
> far more sensible to simply make the base style of any ComputedStyle
> reachable from *that* ComputedStyle. That way we only need to keep
> track of *one* ComputedStyle to access either the animated style,
> or the associated base style.
>
> Bug: 1180159
>
> Change-Id: Ia43755438c0e2ba7bf8281826c5621c7f3dbf55d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3010116
> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
> Reviewed-by: Rune Lillesveen <futhark@chromium.org>
> Reviewed-by: Kevin Ellis <kevers@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#899510}

Bug: 1180159
Change-Id: I90a269f6139d998375ebc87782bc3f519ae4c875
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3017983
Auto-Submit: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#899976}