commit | 492ec13aae28c20cf46236fe34952c7dcc888e0e | [log] [tgz] |
---|---|---|
author | Elad Alon <eladalon@chromium.org> | Tue Nov 02 14:09:19 2021 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Tue Nov 02 14:09:19 2021 |
tree | b173164c6e9c92cc88c5713f8a0fa3d9bb2f3b35 | |
parent | f1f5fc5d57b1853a2ae8f6a922d0fef5d62af9e1 [diff] |
[Region Capture][cropTo][#8] Move crop-ID prod out of Element Crop-ID production should be done in the browser process. Rationale: 1. It removes concerns of interference by a malicious application that could otherwise be forcing collisions of crop-ID. 2. When cropTo() is called, validation of that a crop-ID (a) exists and (b) belongs to the current browsing-context will ultimately be done in the browser process. This CL performs the first step by moving the production of the crop-ID out of Element and into MediaDevices (where produceCropId is exposed to JS). The next CL(s?) will move the production further, to the browser process, with MediaDevices holding a Resolver that can finally fulfill its Promise when the browser process responds with a newly minted crop-ID. Drive-by: Make GetRegionCaptureCropId() return a const-ptr. Bug: 1247761 Change-Id: Ie0aa515584a7ef312bee2fa740f0f318c9b13646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3253017 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by: mark a. foltz <mfoltz@chromium.org> Reviewed-by: Jordan Bayles <jophba@chromium.org> Reviewed-by: Justin Novosad <junov@chromium.org> Cr-Commit-Position: refs/heads/main@{#937320}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.