commit | 494a2e28e14d694e5eaaee6784b8e42520e6e293 | [log] [tgz] |
---|---|---|
author | Kush Sinha <sinhak@chromium.org> | Wed Nov 16 10:29:38 2022 |
committer | Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> | Wed Nov 16 10:29:38 2022 |
tree | b37e495eb50d24134f54b4798f6ebce46c1b716a | |
parent | 95c70d3a7080ffd029d33e3e6c659144fa7c3da6 [diff] |
Reland "crOS: Add additional histogram buckets for account addition result" This is a reland of commit 3aaa3c95d2675b2dd09d0788401e4531fc8d6caf Changes from last commit: - Change BASE_EXPECT_DEATH to EXPECT_DCHECK_DEATH. The former doesn't understand DCHECKs. - Add branded build to Cq-Include-Trybots for early feedback. Original change's description: > crOS: Add additional histogram buckets for account addition result > > The percentage of account addition requests ending up in > `kUnexpectedResponse` is pretty high. We need to drill deeper into the > root cause. As of now, this histogram bucket acts as a catch-all for all > kinds of Mojo issues. > > Add additional histogram buckets to catch Mojo remote disconnections and > Mojo version incompatibility between remote and receiver. > > Bug: 1342001 > Low-Coverage-Reason: Death tests are not included in coverage > Change-Id: I3f17a41f44ba1f2bc868784d6690e007fa05a2f1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4003047 > Reviewed-by: Anastasiia N <anastasiian@chromium.org> > Commit-Queue: Kush Sinha <sinhak@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1069087} Bug: 1342001 Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Change-Id: Ifb494ea2326a2795a23f0b8498582166a4a2b86c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4016373 Reviewed-by: Anastasiia N <anastasiian@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/main@{#1072138}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
To check out the source code locally, don't use git clone
! Instead, follow the instructions on how to get the code.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .
For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.
If you found a bug, please file it at https://crbug.com/new.