[line-clamp] Fix DCHECK when balancing a line-clamp descendant

In https://crrev.com/c/6641006 it was decided to not allow using
`ScoreLineBreaking` with line-clamp involving ellipses that are
considered during line-breaking (i.e. the
`CSSLineClampLineBreakingEllipsis` runtime flag). This was done by
setting the `is_score_line_break_disabled_` flag in
`InlineItemsBuilderTemplate` if the block is a `line-clamp` container.

However, a DCHECK was also added to `ScoreLineBreaker` to verify that
score line breaking was indeed disabled in that case. And if the
line-clamp container is not itself balanced, but an in-flow descendant
of it is, then the score line breaking for that element will not be
disabled, and there will be a DCHECK failure.

In this patch, we solve this by bailing out of `ScoreLineBreaker` in
that case, just like we do if
`line_breaker.ShouldDisableScoreLineBreak()` returns true.

Bug: 40336192
Change-Id: Ibb03db18c1221aa0f2504b0c11891f8efdcc8395
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6727234
Commit-Queue: Andreu Botella <abotella@igalia.com>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1485668}
4 files changed
tree: 36642e4929027ab82d19d354036bce232747ed42
  1. .github/
  2. agents/
  3. android_webview/
  4. apps/
  5. ash/
  6. base/
  7. build/
  8. build_overrides/
  9. buildtools/
  10. cc/
  11. chrome/
  12. chromecast/
  13. chromeos/
  14. codelabs/
  15. components/
  16. content/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia_web/
  23. gin/
  24. google_apis/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. net/
  33. pdf/
  34. ppapi/
  35. printing/
  36. remoting/
  37. rlz/
  38. sandbox/
  39. services/
  40. skia/
  41. sql/
  42. storage/
  43. styleguide/
  44. testing/
  45. third_party/
  46. tools/
  47. ui/
  48. url/
  49. webkit/
  50. .clang-format
  51. .clang-tidy
  52. .clangd
  53. .cursorignore
  54. .git-blame-ignore-revs
  55. .gitallowed
  56. .gitattributes
  57. .gitignore
  58. .gitmodules
  59. .gn
  60. .mailmap
  61. .rustfmt.toml
  62. .vpython3
  63. .yapfignore
  64. ATL_OWNERS
  65. AUTHORS
  66. BUILD.gn
  67. CODE_OF_CONDUCT.md
  68. codereview.settings
  69. CPPLINT.cfg
  70. CRYPTO_OWNERS
  71. DEPS
  72. DIR_METADATA
  73. LICENSE
  74. LICENSE.chromium_os
  75. OWNERS
  76. PRESUBMIT.py
  77. PRESUBMIT_test.py
  78. PRESUBMIT_test_mocks.py
  79. README.md
  80. SECURITY_OWNERS
  81. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.