Google Git
Sign in
chromium / chromium / src / 499c27d84c6f5bb9adc84e8266293e907a4d1c7c
commit499c27d84c6f5bb9adc84e8266293e907a4d1c7c[log] [tgz]
authorJonathan Lee <jonathanjlee@google.com>Wed Feb 21 22:12:30 2024
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Wed Feb 21 22:12:30 2024
tree6c5e362c71407bb85977eb67098a82f700069f69
parent0d3668434f8f0367c1ec231de40d4d48843782ca [diff]
[rebaseline-cl] Warn when rebaselining tests missing locally

Without explicitly listed tests, the tests to rebaseline are derived
verbatim from failures reported by ResultDB. However, when using a
checkout older or newer than the try builds, it's possible for some
failed tests to not exist locally. Log a warning in that case.

This check is similar to but mutually exclusive with [0], which
requires that each explicit test pattern resolves to one or more tests.

[0]: https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/tools/blinkpy/tool/commands/command.py;l=177-178;drc=f842bd21b70c17d9e1d886cbd3c5e765509615c5;bpv=0;bpt=0

Bug: 41483974
Test: git cl issue 5120391
Test: ./blink_tool.py rebaseline-cl --dry-run --patchset=1
Test: No longer crashes with `'e/w/css/c-a-p/anchor-position-auto-003.html' not in the '/' manifest`
Change-Id: Ia286f6c59a7058ba82ff096f9cd3d79a28aebb1f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310564
Reviewed-by: Weizhong Xia <weizhong@google.com>
Commit-Queue: Jonathan Lee <jonathanjlee@google.com>
Cr-Commit-Position: refs/heads/main@{#1263615}
4 files changed
tree: 6c5e362c71407bb85977eb67098a82f700069f69
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. webkit/
  51. clank
  52. internal
  53. ios_internal
  54. native_client
  55. signing_keys
  56. v8
  57. .clang-format
  58. .clang-tidy
  59. .clangd
  60. .eslintrc.js
  61. .git-blame-ignore-revs
  62. .gitallowed
  63. .gitattributes
  64. .gitignore
  65. .gitmodules
  66. .gn
  67. .mailmap
  68. .rustfmt.toml
  69. .vpython3
  70. .yapfignore
  71. ATL_OWNERS
  72. AUTHORS
  73. BUILD.gn
  74. CODE_OF_CONDUCT.md
  75. codereview.settings
  76. DEPS
  77. DIR_METADATA
  78. LICENSE
  79. LICENSE.chromium_os
  80. OWNERS
  81. PRESUBMIT.py
  82. PRESUBMIT_test.py
  83. PRESUBMIT_test_mocks.py
  84. README.md
  85. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure.

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.