commit 4a3a2b8dfc7c77ed2c668b50144f19e7349de57b
author anthie@google.com <anthie@google.com> Fri Dec 06 10:47:46 2024
committer Chromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com> Fri Dec 06 10:47:46 2024
tree fcc1a6f6aa6594f42af21042dfebecc35e776f2e
parent e11097dcf86d6477be9ca7043a9f406d2c7ba733

Reland "Reland "Update avatar badge background color in sign-in interception bubbles""

This reverts commit 05458c3b02be8f91d645922b7388c34714a7588f.

Reason for revert: The failing browsertests from
dice_web_signin_interception_bubble_view_browsertest.cc have been adjusted
to explicitely provide a profile color that is used in the real flow
and meets the DCHECK requirements that we hit otherwise in [1].
Running all the failed builders in this CL (linux_chromium_asan_rel_ng,
win-rel,win11-rel,linux_chromium_cfi_rel_ng).

[1]: https://source.chromium.org/chromium/chromium/src/+/main:ui/gfx/color_utils.cc;l=644

Original change's description:
> Revert "Reland "Update avatar badge background color in sign-in interception bubbles""
>
> This reverts commit 480deeaa0b60ac72d5aabebc2164f333ebabee00.
>
> Reason for revert: Causing ASAN/LSAN test failures:
> https://ci.chromium.org/ui/p/chromium/builders/ci/Linux%20ASan%20LSan%20Tests%20(1)/129774/test-results?sortby=&groupby=
>
> Original change's description:
> > Reland "Update avatar badge background color in sign-in interception bubbles"
> >
> > This reverts commit 53b601431b57a4236f9b1e75d53959f548ad74c1.
> >
> > Reason for revert: No code changes necessary.
> > I have now approved the new reference images for the failing pixel tests. Triggering mega CQ & the win-rel builder that mirrors the failing builder Win10 Tests x64.
> >
> > Original change's description:
> > > Revert "Update avatar badge background color in sign-in interception bubbles"
> > >
> > > This reverts commit de0e29d561febd33ed35c81eb11bb765188492a6.
> > >
> > > Reason for revert: Likely culprit for test failures, see bug
> > >
> > > Bug: 382027496
> > >
> > >
> > > Original change's description:
> > > > Update avatar badge background color in sign-in interception bubbles
> > > >
> > > > The background color of the avatar badge is set to match the
> > > > the header image color of the container it belongs to.
> > > > This change applies to the badge for both supervised users (kite
> > > > icon) and enterprise users (domain icon) that are displayed in the
> > > > sign-in interception bubble.
> > > >
> > > > The color of the badge icon is also dynamically set and derived
> > > > from the profile highlight color using profile_colors_util's
> > > > `GetProfileForegroundIconColor`.
> > > >
> > > > Screenshot of the result:
> > > > https://screenshot.googleplex.com/78QHcreAZGuMon3
> > > > https://screenshot.googleplex.com/Ak5tNPn2CAa7Vsz
> > > > https://screenshot.googleplex.com/6HntySVXAMPNciA (dark)
> > > >
> > > > Bug: 379892923
> > > > Change-Id: I6953ec4ce195895fed7a4c675657f7b147b3d67a
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6062800
> > > > Reviewed-by: Nohemi Fernandez <fernandex@google.com>
> > > > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com>
> > > > Reviewed-by: David Roger <droger@chromium.org>
> > > > Commit-Queue: Anthi Orfanou <anthie@google.com>
> > > > Cr-Commit-Position: refs/heads/main@{#1390899}
> > >
> > > Bug: 379892923
> > > Change-Id: If3b927d5d7cc1845c0dcef7f40b1560cbc6f88c8
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6063589
> > > Auto-Submit: Florian Jacky <fjacky@chromium.org>
> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Owners-Override: Florian Jacky <fjacky@chromium.org>
> > > Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Cr-Commit-Position: refs/heads/main@{#1390950}
> >
> > Bug: 382027496
> > Bug: 379892923
> > Change-Id: I24a7c331367dcc314a6dfab262d4ff5fab8e9856
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6063592
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Reviewed-by: David Roger <droger@chromium.org>
> > Commit-Queue: Anthi Orfanou <anthie@google.com>
> > Cr-Commit-Position: refs/heads/main@{#1391733}
>
> Bug: 382027496
> Bug: 379892923
> Change-Id: I87fc9c03911361d02b02400f645510e38a4c9a2e
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6070759
> Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org>
> Owners-Override: Thomas Guilbert <tguilbert@chromium.org>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Cr-Commit-Position: refs/heads/main@{#1391806}

Bug: 382027496, 379892923
Change-Id: I9137e9e0f0ff64e5b0c8d61095098473aab10fa1
Cq-Include-Trybots: luci.chromium.try:linux_chromium_asan_rel_ng,win-rel,win11-rel,linux_chromium_cfi_rel_ng
Include-Ci-Only-Tests: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6074533
Reviewed-by: David Roger <droger@chromium.org>
Commit-Queue: Anthi Orfanou <anthie@google.com>
Cr-Commit-Position: refs/heads/main@{#1392797}