Google Git
Sign in
chromium / chromium / src / 4a52a0879dcd76c4c6ecafc2d874f8f529ee1591
commit4a52a0879dcd76c4c6ecafc2d874f8f529ee1591[log] [tgz]
authorAlexander Alekseev <alemate@chromium.org>Tue Aug 24 14:58:48 2021
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Tue Aug 24 14:58:48 2021
treeb623ea350ad5a04335e8a464a43fd6268e288865
parent2657f3eb68686173aa2dbab4493fbd415846518b [diff]
[ChromeOS tests] Make LoginManager tests wait for WebUI loaded.

This CL adds WizardControllerCreated event, ProfilePreparedWaiter
object, and makes LoginManagerMixin wait for WizardControllerCreated
and waif for profile prepared in LoginAsNewUser. It also allows
SessionStateWaiter to detect session change condition if it happened
before Wait was called.

Waiting for ProfilePrepared makes safe for most of the tests to
do user checks after login (and those that need immediate status
do not use this flow).

Waiting for WizardControllerCreated allows for it to be created
asynchronously (in the future change).

Bug: 1218161
Change-Id: Id4b05199a730d7925b1e8b65f26f96d542a0cd00
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3108506
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Auto-Submit: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#914728}
20 files changed
tree: b623ea350ad5a04335e8a464a43fd6268e288865
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. cloud_print/
  13. codelabs/
  14. components/
  15. content/
  16. courgette/
  17. crypto/
  18. dbus/
  19. device/
  20. docs/
  21. extensions/
  22. fuchsia/
  23. gin/
  24. google_apis/
  25. google_update/
  26. gpu/
  27. headless/
  28. infra/
  29. ios/
  30. ipc/
  31. jingle/
  32. media/
  33. mojo/
  34. native_client_sdk/
  35. net/
  36. pdf/
  37. ppapi/
  38. printing/
  39. remoting/
  40. rlz/
  41. sandbox/
  42. services/
  43. skia/
  44. sql/
  45. storage/
  46. styleguide/
  47. testing/
  48. third_party/
  49. tools/
  50. ui/
  51. url/
  52. weblayer/
  53. .clang-format
  54. .clang-tidy
  55. .eslintrc.js
  56. .git-blame-ignore-revs
  57. .gitattributes
  58. .gitignore
  59. .gn
  60. .mailmap
  61. .vpython
  62. .vpython3
  63. .yapfignore
  64. AUTHORS
  65. BUILD.gn
  66. CODE_OF_CONDUCT.md
  67. codereview.settings
  68. DEPS
  69. DIR_METADATA
  70. ENG_REVIEW_OWNERS
  71. LICENSE
  72. LICENSE.chromium_os
  73. OWNERS
  74. PRESUBMIT.py
  75. PRESUBMIT_test.py
  76. PRESUBMIT_test_mocks.py
  77. README.md
  78. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.