Google Git
Sign in
chromium / chromium / src / 4a70e5b17bc63c5b5234176633c369310e192d11
commit4a70e5b17bc63c5b5234176633c369310e192d11[log] [tgz]
authorLeonid Baraz <lbaraz@chromium.org>Fri Sep 30 20:12:04 2022
committerChromium LUCI CQ <chromium-scoped@luci-project-accounts.iam.gserviceaccount.com>Fri Sep 30 20:12:04 2022
tree42266db161f8578d4fa4b911ee35ed2bdb2f06ad
parent0b1af11c4094c055b4c9d5590e5885ba2a62120b [diff]
Fail pending Enqueues if actual queue fails.

Make it so that when Speculative queue fails to create actual queue, all
pending Enqueues are aborted with the same error status.
This way we prevent a possibility that pemanent failure to create queue
(e.g., missing DM token) cause advance Enqueues to never finish.

Added unittest for this case.

Also, slightly improved tests readability.

Bug: b:239583016
Change-Id: If26b9ff2bf0fffb912a80c240d411a49473db416
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3931028
Commit-Queue: Vignesh Shenvi <vshenvi@google.com>
Auto-Submit: Leonid Baraz <lbaraz@chromium.org>
Reviewed-by: Vignesh Shenvi <vshenvi@google.com>
Cr-Commit-Position: refs/heads/main@{#1053735}
3 files changed
tree: 42266db161f8578d4fa4b911ee35ed2bdb2f06ad
  1. android_webview/
  2. apps/
  3. ash/
  4. base/
  5. build/
  6. build_overrides/
  7. buildtools/
  8. cc/
  9. chrome/
  10. chromecast/
  11. chromeos/
  12. codelabs/
  13. components/
  14. content/
  15. courgette/
  16. crypto/
  17. dbus/
  18. device/
  19. docs/
  20. extensions/
  21. fuchsia_web/
  22. gin/
  23. google_apis/
  24. google_update/
  25. gpu/
  26. headless/
  27. infra/
  28. ios/
  29. ipc/
  30. media/
  31. mojo/
  32. native_client_sdk/
  33. net/
  34. pdf/
  35. ppapi/
  36. printing/
  37. remoting/
  38. rlz/
  39. sandbox/
  40. services/
  41. skia/
  42. sql/
  43. storage/
  44. styleguide/
  45. testing/
  46. third_party/
  47. tools/
  48. ui/
  49. url/
  50. weblayer/
  51. .clang-format
  52. .clang-tidy
  53. .eslintrc.js
  54. .git-blame-ignore-revs
  55. .gitattributes
  56. .gitignore
  57. .gn
  58. .mailmap
  59. .rustfmt.toml
  60. .vpython3
  61. .yapfignore
  62. AUTHORS
  63. BUILD.gn
  64. CODE_OF_CONDUCT.md
  65. codereview.settings
  66. DEPS
  67. DIR_METADATA
  68. ENG_REVIEW_OWNERS
  69. LICENSE
  70. LICENSE.chromium_os
  71. OWNERS
  72. PRESUBMIT.py
  73. PRESUBMIT_test.py
  74. PRESUBMIT_test_mocks.py
  75. README.md
  76. WATCHLISTS
README.md

Logo Chromium

Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.

The project's web site is https://www.chromium.org.

To check out the source code locally, don't use git clone! Instead, follow the instructions on how to get the code.

Documentation in the source is rooted in docs/README.md.

Learn how to Get Around the Chromium Source Code Directory Structure .

For historical reasons, there are some small top level directories. Now the guidance is that new top level directories are for product (e.g. Chrome, Android WebView, Ash). Even if these products have multiple executables, the code should be in subdirectories of the product.

If you found a bug, please file it at https://crbug.com/new.