commit | 4a7f224d18674c23cae8acdf2bfb3df1edd04851 | [log] [tgz] |
---|---|---|
author | David Black <dmblack@google.com> | Thu Jan 10 01:59:58 2019 |
committer | Commit Bot <commit-bot@chromium.org> | Thu Jan 10 01:59:58 2019 |
tree | 33c0d8dee5e39aa41901398d68f2afd21f2f9710 | |
parent | c10789c840712a9bfbf6343c416380fc295bf4bb [diff] |
Pull AssistantCardElementView out of UiElementContainerView. This will make it easier to maintain both AssistantCardElementView and UiElementContainerView moving forward. Note that this CL also changes AssistantCardElementView to extend from views::View instead of views::NativeViewHost. Previously, we used views::NativeViewHost because we needed a reference to the native view that web contents would paint to for animation purposes. Now, the native view is exposed through NavigableContents so we don't need to extend views::NativeViewHost any longer. Known issues: - Cards are not currently focusable (existing issue - WIP). - There seems to be some whitespace added to the bottom of cards when the content is scrollable. Not sure what that is about but will continue to investigate. Bug: b:120682808 Change-Id: I55a1e03e01979bbe6f4ca932aa73df1180841cda Reviewed-on: https://chromium-review.googlesource.com/c/1404314 Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#621417}
Chromium is an open-source browser project that aims to build a safer, faster, and more stable way for all users to experience the web.
The project's web site is https://www.chromium.org.
Documentation in the source is rooted in docs/README.md.
Learn how to Get Around the Chromium Source Code Directory Structure .